feat(dashboards): POC for sharing dashboards#82455
feat(dashboards): POC for sharing dashboards#82455harshithadurai wants to merge 2 commits intomasterfrom
Conversation
github-actions
bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| except Organization.DoesNotExist: | ||
| return Response({"detail": "Organization not found"}, status=404) | ||
| except Exception as e: | ||
| return Response({"error": str(e)}, status=400) |
Check warning
Code scanning / CodeQL
Information exposure through an exception
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 year ago
To fix the problem, we should log the detailed exception message on the server and return a generic error message to the user. This approach ensures that sensitive information is not exposed to the user while still allowing developers to access the necessary details for debugging.
- Modify the exception handling block to log the exception message and stack trace.
- Return a generic error message to the user instead of the actual exception message.
| @@ -94,3 +94,4 @@ | ||
| except Exception as e: | ||
| return Response({"error": str(e)}, status=400) | ||
| self.logger.error("An error occurred: %s", str(e), exc_info=True) | ||
| return Response({"error": "An internal error has occurred."}, status=400) | ||
|
|
❌ 8 Tests Failed:
View the top 3 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
Hey! We are cleaning up our PR backlog to cut down on noise. Since this PR was created more than 6 months ago and doesn't have much recent activity, I'm closing it. If you’re still interested in seeing this land, please feel free to reopen. |
2 participants
DRAFT: POC for sharing dashboards